Fix erroneous handling of shared dependencies (ie dependencies on roles)
in CREATE OR REPLACE FUNCTION. The original code would update pg_shdepend
as if a new function was being created, even if it wasn't, with two bad
consequences: pg_shdepend might record the wrong owner for the function,
and any dependencies for roles mentioned in the function's ACL would be lost.
The fix is very easy: just don't touch pg_shdepend at all when doing a
Also update the CREATE FUNCTION reference page, which never explained
exactly what changes and doesn't change in a function replacement.
In passing, fix the CREATE VIEW reference page similarly; there's no
code bug there, but the docs didn't say what happens.
create_function.sgml (r1.86 -> r1.87)
create_view.sgml (r1.41 -> r1.42)
pg_proc.c (r1.165 -> r1.166)
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2009-10-02 18:13:10|
|Subject: pgsql: Fix erroneous handling of shared dependencies (ie dependencies on |
|Previous:||From: Alvaro Herrera||Date: 2009-10-02 17:58:21|
|Subject: pgsql: Ensure that a cursor has an immutable snapshot throughout its |