Re: TODO item: Allow more complex user/database default GUC settings

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bernd Helmle <mailings(at)oopsware(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TODO item: Allow more complex user/database default GUC settings
Date: 2009-10-01 21:22:06
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bernd Helmle escribió:
> --On 30. September 2009 13:19:53 -0400 Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
> >>I think it would be helpful if you could post ONE patch with all the
> >>changes and all the new files in the diff. AIUI, "the" patch is now
> >>split across three separate emails. :-(
> >
> >That's correct, here it is.
> Some additional notes:
> - ALTER ROLE ... IN DATABASE is missing some documentation. If you
> want, i can work on this.


> - The patch as is has still some locking problems (AlterRoleSet()
> has a XXX about that): I've managed to create dead entries for a
> role or a database in pg_db_role_setting while altering and dropping
> a role/database in two concurrent sessions.

Yeah, I was playing with that too. I think we need a few extra
LockSharedObject calls, and not only in the new code :-( (This troubles
me in the case of databases, because we already grab a lock on it during
connection establishing, so this could cause extra contention there.)

Alvaro Herrera
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2009-10-01 21:23:52 Re: FSM search modes
Previous Message Robert Haas 2009-10-01 21:18:54 Re: FSM search modes