pgsql: Try to make silent_mode behave somewhat reasonably.

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Try to make silent_mode behave somewhat reasonably.
Date: 2009-08-24 20:08:32
Message-ID: 20090824200832.38C9A75331E@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Try to make silent_mode behave somewhat reasonably.

Instead of sending stdout/stderr to /dev/null after forking away from the
terminal, send them to postmaster.log within the data directory. Since
this opens the door to indefinite logfile bloat, recommend even more
strongly that log output be redirected when using silent_mode.

Move the postmaster's initial calls of load_hba() and load_ident() down
to after we have started the log collector, if we are going to. This
is so that errors reported by them will appear in the "usual" place.

Reclassify silent_mode as a LOGGING_WHERE, not LOGGING_WHEN, parameter,
since it's got absolutely nothing to do with the latter category.

In passing, fix some obsolete references to -S ... this option hasn't
had that switch letter for a long time.

Back-patch to 8.4, since as of 8.4 load_hba() and load_ident() are more
picky (and thus more likely to fail) than they used to be. This entire
change was driven by a complaint about those errors disappearing into
the bit bucket.

Modified Files:
--------------
pgsql/doc/src/sgml:
config.sgml (r1.223 -> r1.224)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.223&r2=1.224)
pgsql/src/backend/postmaster:
postmaster.c (r1.589 -> r1.590)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c?r1=1.589&r2=1.590)
pgsql/src/backend/utils/misc:
guc.c (r1.510 -> r1.511)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.510&r2=1.511)
postgresql.conf.sample (r1.263 -> r1.264)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample?r1=1.263&r2=1.264)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-08-24 20:08:40 pgsql: Try to make silent_mode behave somewhat reasonably.
Previous Message Tom Lane 2009-08-24 18:09:54 pgsql: Small correction to previous patch: we shouldn't