| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Marek Černocký <marek(at)manet(dot)cz> |
| Subject: | Re: Second l10n patch |
| Date: | 2009-08-03 11:03:39 |
| Message-ID: | 200908031303.40037.guillaume@lelarge.info |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
> > 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
> > > Hi,
> > >
> > > I send patch. It solves translation for object type names in reports.
> >
> > Should code like this use wxPLURAL?
> >
> > int section = report->XmlCreateSection(wxString::Format(_("%s
> > dependents"), object->GetTranslatedTypeName().c_str()));
>
> No. We need wxPLURAL when we have a variable that tells us if it is plural
> or not. In this code, there's nothing that gives us a hint about it.
>
> Note that I didn't actually try this patch. Only read it.
Just tried it, and it works the way I think it should. I can commit it if you
want.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2009-08-03 11:04:34 | Re: Second l10n patch |
| Previous Message | Guillaume Lelarge | 2009-08-03 10:33:56 | Re: Second l10n patch |