|From:||Andres Freund <andres(at)anarazel(dot)de>|
|Cc:||"Sergey V(dot) Karpov" <karpov(at)sao(dot)ru>|
|Subject:||Re: improvements for dict_xsyn extended synonym dictionary - RRR|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Sorry that the second round took almost as long as the first one...
On Monday 27 July 2009 12:01:46 Sergey V. Karpov wrote:
> > - Imho mode=MAP should error out if keeporig is false
> > - I personally find the the names for the different modes a bit
> > nondescriptive. One possibility would be to introduce parameters like:
> > - matchorig
> > - matchsynonym
> > - keeporig
> > - keepsynonym
> > That sounds way much easier to grasp for me.
> Yes, I agree. In such a way user has the complete (and more
> straightforward) control over the dictionary behaviour.
> Here is the revised patch version, with following options:
> * matchorig controls whether the original word is accepted by the
> dictionary. Default is true.
> * keeporig controls whether the original word is included (if true)
> in results, or only its synonyms (if false). Default is true.
> * matchsynonyms controls whether any of the synonyms is accepted by
> the dictionary (if true). Default is false.
> * keepsynonyms controls whether synonyms are returned by the
> dictionary (if true). Default is true.
> Defaults are set to keep default behaviour compatible with original
Looks nice. The only small gripe I have is that the patch adds trailing
whitespaces at a lot of places...
Except maybe that I do see no need for changes anymore...
|Next Message||Steve Prentice||2009-07-29 23:55:05||RFD: Don't force plpgsql IN parameters to constant|
|Previous Message||Josh Williams||2009-07-29 21:31:53||Re: multi-threaded pgbench|