Skip site navigation (1) Skip section navigation (2)

Re: Sampling profiler updated

From: Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Dimitri Fontaine <dfontaine(at)hi-media(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Sampling profiler updated
Date: 2009-07-21 05:57:24
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Dimitri Fontaine <dfontaine(at)hi-media(dot)com> wrote:

> WARNING:  condition stack overflow: 10
> So I'm going to change patch state to "Returned with Feedback" as I  
> guess we'll need to talk about the issue and find a way to solve it,  
> and I don't think this state prevent from getting back to the patch in  
> this same fest.

Oops, I must fix it. I didn't test well the default stack depth (10).
I'd better not have limitation of condition stack.

BTW, I hope I have enough feedbacks from reviewers if the patch is
"Returned with Feedback". Are there any issues I need to fix or improve
by the next commitfest?

I feel we don't have enough discussion about the feature, like:
  * Is is useful enough? or are there any idea to be more useful?
  * Is it ok we have two versions of profiling? (this and dtrace probes)
  * Is the quality of the patch enough in terms of implmentation?

ITAGAKI Takahiro
NTT Open Source Software Center

In response to


pgsql-hackers by date

Next:From: Dimitri FontaineDate: 2009-07-21 06:09:54
Subject: Re: Sampling profiler updated
Previous:From: Itagaki TakahiroDate: 2009-07-21 05:23:54
Subject: Re: pg_restore --clean vs. large object

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group