Re: fix: plpgsql: return query and dropped columns problem

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Sergey Burladyan <eshkinkot(at)gmail(dot)com>, Michael Tenenbaum <michael(at)strategic-techs(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: fix: plpgsql: return query and dropped columns problem
Date: 2009-07-20 15:09:14
Message-ID: 20090720150914.GK4938@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Tom Lane escribió:
> Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> writes:
> > this one applies, compiles and it actually fixes the bug...
>
> And introduces a bunch of new ones. Surely you don't think that version
> of compatible_tupdesc() is good enough.

Getting rid of the check on natts was "ungood" ... it needs to compare
the number of undropped columns of both tupdescs.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jaime Casanova 2009-07-20 16:34:27 Re: fix: plpgsql: return query and dropped columns problem
Previous Message Jaime Casanova 2009-07-20 15:08:18 Re: fix: plpgsql: return query and dropped columns problem

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2009-07-20 15:34:24 Re: [PATCH] SE-PgSQL/tiny rev.2193
Previous Message Jaime Casanova 2009-07-20 15:08:18 Re: fix: plpgsql: return query and dropped columns problem