pgsql: Adjust pg_dumpall so that it emits ENCODING, LC_COLLATE, and

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Adjust pg_dumpall so that it emits ENCODING, LC_COLLATE, and
Date: 2009-05-10 02:51:44
Message-ID: 20090510025144.4F92F754067@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Adjust pg_dumpall so that it emits ENCODING, LC_COLLATE, and LC_CTYPE options
in its CREATE DATABASE commands only for databases that have settings
different from the installation defaults. This is a low-tech method of
avoiding unnecessary platform dependencies in dump files. Eventually we ought
to have a platform-independent way of specifying LC_COLLATE and LC_CTYPE, but
that's not going to happen for 8.4, and this patch at least avoids the issue
for people who aren't setting up per-database locales. ENCODING doesn't have
the platform dependency problem, but it seems consistent to make it act the
same as the locale settings.

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_dumpall.c (r1.124 -> r1.125)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c?r1=1.124&r2=1.125)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-05-10 22:45:28 pgsql: Make a marginal performance improvement in predicate_implied_by
Previous Message User H-saito 2009-05-10 01:31:09 pg-migrator - pg_migrator: Ooops, miss coding...