Re: Annoying error messages in _dosmaperr

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> It's probably not worth the trouble to do that, but maybe we could just
> have a FRONTEND_DEBUG compile time switch:
> That would at least leave the code in place if anyone needed the
> debugging output badly enough to do a custom build.

It would be a simplest solution.

I grep-ed sources with #ifndef FRONTEND and #ifdef FRONTEND,
but there are no other "DEBUG or stderr" codes. All other codes
are "WARNING/LOG or stderr", so I keep all of them as-is.

Index: src/port/win32error.c
===================================================================
--- src/port/win32error.c (HEAD)
+++ src/port/win32error.c (working copy)
@@ -180,7 +180,7 @@
ereport(DEBUG5,
(errmsg_internal("mapped win32 error code %lu to %d",
e, errno)));
-#else
+#elif FRONTEND_DEBUG
fprintf(stderr, _("mapped win32 error code %lu to %d"), e, errno);
#endif
return;

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center