pgsql: Fix pg_dump/pg_restore's ExecuteSqlCommand() to behave suitably

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dump/pg_restore's ExecuteSqlCommand() to behave suitably
Date: 2008-08-16 02:25:06
Message-ID: 20080816022506.85037755315@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix pg_dump/pg_restore's ExecuteSqlCommand() to behave suitably if PQexec
returns NULL instead of a PGresult. The former coding would fail, which
is OK, but it neglected to give you the PQerrorMessage that might tell
you why. In the oldest branches, there was another problem: it'd sometimes
report PQerrorMessage from the wrong connection.

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_backup_db.c (r1.79 -> r1.80)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_backup_db.c?r1=1.79&r2=1.80)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-08-16 02:25:11 pgsql: Fix pg_dump/pg_restore's ExecuteSqlCommand() to behave suitably
Previous Message Bruce Momjian 2008-08-16 02:15:34 pgsql: Add to TODO: > > * Prevent query cancel packets from being