Re: pgsql: Make the pg_stat_activity view call a SRF

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Tom Lane wrote:
> >> Why not declare it with OUT parameters, instead?
>
> > That does sound like a very good idea... I did notice that as being
> > a problem, but didn't know how to fix it without thinking more :-)
> > How do I do that in pg_proc.h? Is there some other function that
> > does this that I can peek at for inspiration?
>
> Sure, see pg_timezone_abbrevs(), pg_timezone_names().
>
> (This only started to work recently, which is why we have so many
> record-returning functions that don't do it that way. It might be
> an idea to fix them all sooner or later.)

Wow, that was easy. Not sure where I got the impression it was hard
from - probably last looked at it before it was made easy, and didn't
re-check :-)

Updated the pg_stat_get_activity() function to use this.

And yes, I agree that it's probably a very good idea to go over our
other SRFs and fix them all. I can take a look at that eventually, but
for now I think we stick it on the TODO?

//Magnus