From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Make the pg_stat_activity view call a SRF |
Date: | 2008-05-08 09:00:09 |
Message-ID: | 20080508110009.623b13bd@mha-laptop.hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> > Tom Lane wrote:
> >> Why not declare it with OUT parameters, instead?
>
> > That does sound like a very good idea... I did notice that as being
> > a problem, but didn't know how to fix it without thinking more :-)
> > How do I do that in pg_proc.h? Is there some other function that
> > does this that I can peek at for inspiration?
>
> Sure, see pg_timezone_abbrevs(), pg_timezone_names().
>
> (This only started to work recently, which is why we have so many
> record-returning functions that don't do it that way. It might be
> an idea to fix them all sooner or later.)
Wow, that was easy. Not sure where I got the impression it was hard
from - probably last looked at it before it was made easy, and didn't
re-check :-)
Updated the pg_stat_get_activity() function to use this.
And yes, I agree that it's probably a very good idea to go over our
other SRFs and fix them all. I can take a look at that eventually, but
for now I think we stick it on the TODO?
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | User Achernow | 2008-05-08 11:30:12 | libpqtypes - libpqtypes: removed libpqtypes.h comments since they are |
Previous Message | Magnus Hagander | 2008-05-08 08:59:00 | pgsql: Make the new pg_stat_get_activity use OUT parameters, so you |
From | Date | Subject | |
---|---|---|---|
Next Message | Zoltan Boszormenyi | 2008-05-08 09:56:28 | Re: Auto-updated fields |
Previous Message | Achilleas Mantzios | 2008-05-08 07:09:48 | dbmirror - migration to 8.3 from 7.4 |