| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
| Date: | 2008-04-28 20:55:15 |
| Message-ID: | 20080428205514.GH5761@alvh.no-ip.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera escribió:
> Tom Lane escribió:
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > > Tom Lane escribió:
> > >> They're logically different things, and after I get done putting a parse
> > >> location field into A_Const, they'll still be physically different too.
> >
> > > Aha. Are you working from Brendan's patch? I was going to commit it.
> >
> > Sure, go ahead. I was going to add the parse location at the same time,
> > but it can perfectly well be done as a separate patch.
>
> I came up with the attached patch. I added the location bits (although
> I am unsure if I got the locations right in the parser), but they are
> unused -- figuring out how to use them would take me longer than I can
> to spend on this.
Hmm, I'm now wondering if the location should be added to Value as well,
so that it can be passed down to Const?
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-28 20:57:11 | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
| Previous Message | Alvaro Herrera | 2008-04-28 20:52:08 | Re: WANTED: VACUUM SUMMARY |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-04-28 20:57:11 | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |
| Previous Message | Alvaro Herrera | 2008-04-28 20:25:03 | Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[]) |