Skip site navigation (1) Skip section navigation (2)

Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search

From: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
To: pgsql-performance(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Fix TransactionIdIsCurrentTransactionId() to use binary search
Date: 2008-04-26 13:10:53
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committerspgsql-hackerspgsql-performance
On Friday 25 April 2008 17:32, Tom Lane wrote:
> Robert Treat <xzilla(at)users(dot)sourceforge(dot)net> writes:
> > Oddly some dtrace profiling gave me this, which is pretty different, but
> > certainly doesn't have concerns about TransactionIdIsCurrentTransactionId
> .... which seems to pretty much destroy your thesis, no?

How so? Before the patch we bog down for hours, spending 99% of our time in  
TransactionIdIsCurrentTransactionId, after the patch everything performs well 
(really better than before) and we spend so little time in 
TransactionIdIsCurrentTransactionId it barely shows up on the radar. 

Note I'm open to the idea that TransactionIdIsCurrentTransactionId itself is 
not the problem, but that something else changed between 8.1 and 8.3 that 
exposes TransactionIdIsCurrentTransactionId as a problem.  Changing to a 
binary search for TransactionIdIsCurrentTransactionId  makes that a non-issue 

Robert Treat
Build A Brighter LAMP :: Linux Apache {middleware} PostgreSQL

In response to


pgsql-performance by date

Next:From: Adonias MalossoDate: 2008-04-26 13:25:22
Subject: Best practice to load a huge table from ORACLE to PG
Previous:From: Gregory StarkDate: 2008-04-26 06:21:21
Subject: Re: Sun Talks about MySQL

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2008-04-26 13:33:17
Subject: Re: Proposed patch - psql wraps at window width
Previous:From: Hannes DorbathDate: 2008-04-26 09:01:02
Subject: Re: MERGE Specification

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2008-04-26 13:44:23
Subject: Re: Re: [COMMITTERS] pgsql: Update: < * Allow addingenumerated values to an existing
Previous:From: User EggyknapDate: 2008-04-25 23:15:32
Subject: pllolcode - pllolcode: Remove debug code

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group