pgsql: Remove transformAlterTableStmt's kluge to replace

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove transformAlterTableStmt's kluge to replace
Date: 2008-04-24 20:46:49
Message-ID: 20080424204649.D42D87559CC@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove transformAlterTableStmt's kluge to replace ColumnDef.is_not_null
flags by separate AT_SetNotNull subcommands. That was always ugly and
inefficient, and it's now clear that it was merely a partial workaround
for the bug just identified in ATExecAddColumn. This is just code
beautification not a bug fix, so no back-patch.

Brendan Jurd, with some trivial additional cleanup by me.

Modified Files:
--------------
pgsql/src/backend/parser:
parse_utilcmd.c (r2.11 -> r2.12)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.11&r2=2.12)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-24 20:57:34 pgsql: Update TODO item: > * Allow adding/renaming/removing enumerated
Previous Message Bruce Momjian 2008-04-24 20:29:16 pgsql: Update: < * Allow adding enumerated values to an existing