pgsql: Use error message wordings for permissions checks on .pgpass and

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Use error message wordings for permissions checks on .pgpass and
Date: 2008-03-31 02:43:14
Message-ID: 20080331024314.BA7A27558E7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Use error message wordings for permissions checks on .pgpass and SSL private
key files that are similar to the one for the postmaster's data directory
permissions check. (I chose to standardize on that one since it's the most
heavily used and presumably best-wordsmithed by now.) Also eliminate explicit
tests on file ownership in these places, since the ensuing read attempt must
fail anyway if it's wrong, and there seems no value in issuing the same error
message for distinct problems. (But I left in the explicit ownership test in
postmaster.c, since it had its own error message anyway.) Also be more
specific in the documentation's descriptions of these checks. Per a gripe
from Kevin Hunter.

Modified Files:
--------------
pgsql/doc/src/sgml:
libpq.sgml (r1.256 -> r1.257)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/libpq.sgml?r1=1.256&r2=1.257)
runtime.sgml (r1.410 -> r1.411)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/runtime.sgml?r1=1.410&r2=1.411)
pgsql/src/backend/libpq:
be-secure.c (r1.83 -> r1.84)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/libpq/be-secure.c?r1=1.83&r2=1.84)
pgsql/src/backend/postmaster:
postmaster.c (r1.553 -> r1.554)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c?r1=1.553&r2=1.554)
pgsql/src/interfaces/libpq:
fe-connect.c (r1.356 -> r1.357)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-connect.c?r1=1.356&r2=1.357)
fe-secure.c (r1.103 -> r1.104)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-secure.c?r1=1.103&r2=1.104)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-03-31 03:34:27 pgsql: Fix my brain fade in TRUNCATE triggers patch: can't release
Previous Message Tom Lane 2008-03-31 01:33:13 pgsql: Fix a number of places that were making file-type tests