Re: Suppress compiler warnings on mingw

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeremy Drake <pgsql(at)jdrake(dot)com>
Subject: Re: Suppress compiler warnings on mingw
Date: 2008-03-17 03:04:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> Then try using %lu and no casts. That should get rid of the warnings the
> proper way.

Ok, I rewrote it to use %lu for format strings.

Jeremy Drake <pgsql(at)jdrake(dot)com> wrote:
> sizeof(DWORD) is always 4, even on 64-bit windows. sizeof(long) is also
> always 4.

I got it. This change will work on 64-bit windows, because DWORD is
defined as 'unsigned long' there, too. We need to support LLP64
compliers in advance, though.

ITAGAKI Takahiro
NTT Open Source Software Center

Attachment Content-Type Size
mingw-warnings.patch application/octet-stream 4.6 KB

In response to


Browse pgsql-patches by date

  From Date Subject
Next Message Kohei KaiGai 2008-03-17 04:25:40 [0/4] Proposal of SE-PostgreSQL patches
Previous Message Tom Lane 2008-03-17 02:53:02 Re: updated hash functions for postgresql v1