| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Marko Kreen <markokr(at)gmail(dot)com> |
| Cc: | Postgres Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Cleaner API for appendStringInfoVA |
| Date: | 2008-03-07 20:22:20 |
| Message-ID: | 200803072022.m27KMKE04274@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Patch rejected. Sorry. Comment is:
The patch of very dubious portability and I'm not even convinced that
it'd provide a net performance improvement.
---------------------------------------------------------------------------
Marko Kreen wrote:
> Attached patch moves decision how much more room to allocate
> from callers of appendStringInfoVA to inside the function,
> where more info is available.
>
> On systems with broken vsnprintf() it falls back
> to doubleing the buffer.
>
> Fixme: the +1 could be something larger? Aligned?
>
> --
> marko
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2008-03-07 20:59:17 | Re: CopyReadLineText optimization |
| Previous Message | Bruce Momjian | 2008-03-07 20:06:24 | Re: [PATCHES] a tsearch2 (8.2.4) dictionary that only filters out stopwords |