Skip site navigation (1) Skip section navigation (2)

pgsql: Fix several memory leaks when rescanning SRFs.

From: neilc(at)postgresql(dot)org (Neil Conway)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix several memory leaks when rescanning SRFs.
Date: 2008-02-29 02:49:47
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-committers
Log Message:
Fix several memory leaks when rescanning SRFs. Arrange for an SRF's
"multi_call_ctx" to be a distinct sub-context of the EState's per-query
context, and delete the multi_call_ctx as soon as the SRF finishes
execution. This avoids leaking SRF memory until the end of the current
query, which is particularly egregious when the SRF is scanned
multiple times. This change also fixes a leak of the fields of the
AttInMetadata struct in shutdown_MultiFuncCall().

Also fix a leak of the SRF result TupleDesc when rescanning a
FunctionScan node. The TupleDesc is allocated in the per-query context
for every call to ExecMakeTableFunctionResult(), so we should free it
after calling that function. Since the SRF might choose to return
a non-expendable TupleDesc, we only free the TupleDesc if it is
not being reference-counted.

Backpatch to 8.3 and 8.2 stable branches.


Modified Files:
        nodeFunctionscan.c (r1.40.2.1 -> r1.40.2.2)
        funcapi.c (r1.31 -> r1.31.2.1)

pgsql-committers by date

Next:From: Peter EisentrautDate: 2008-02-29 10:34:51
Subject: pgsql: Write the objfiles.txt rules in a way that is compatible with GNU
Previous:From: Neil ConwayDate: 2008-02-29 02:49:43
Subject: pgsql: Fix several memory leaks when rescanning SRFs.

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group