| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, depesz <depesz(at)depesz(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] BUG #3799: csvlog skips some logs |
| Date: | 2007-12-10 15:11:44 |
| Message-ID: | 20071210151144.GE8036@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
Andrew Dunstan wrote:
> Not sure I understand what this comment I noticed on a very brief glance is
> about:
>
> /* assume no newlines in funcname or filename... */
>
> If it's about what to quote, we need to quote anything that might contain a newline, quote or comma. Filenames certainly come into that category.
Huh, sorry, that's a leftover comment. The inserted string is quoted
inside appendCSVLiteral. Thanks, I'll fix it.
--
Alvaro Herrera http://www.amazon.com/gp/registry/DXLWNGRJD34J
"No es bueno caminar con un hombre muerto"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-12-10 15:14:55 | Re: [HACKERS] BUG #3799: csvlog skips some logs |
| Previous Message | Andrew Dunstan | 2007-12-10 15:04:46 | Re: [HACKERS] BUG #3799: csvlog skips some logs |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-12-10 15:14:55 | Re: [HACKERS] BUG #3799: csvlog skips some logs |
| Previous Message | Gregory Stark | 2007-12-10 15:05:04 | O(n^2) aggregates |