| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: vacuum as flags in PGPROC |
| Date: | 2007-10-24 14:13:10 |
| Message-ID: | 20071024141310.GF6559@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > In the spirit of incremental improvement, here is a patch that turns the
> > couple of bools in PGPROC into a bitmask, and associated fallout.
>
> Maybe declare the field as uint8 instead of char? Otherwise, +1.
I'm wondering if it's safe to do something like
MyProc->vacuumFlags |= PROC_FOR_XID_WRAPAROUND
without holding the ProcArrayLock. It seems in practice a type smaller
than "int" (which uint8 always is) is always stored atomically so this
shouldn't be a problem.
--
Alvaro Herrera http://www.PlanetPostgreSQL.org/
"La rebeldía es la virtud original del hombre" (Arthur Schopenhauer)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-24 14:31:17 | Re: vacuum as flags in PGPROC |
| Previous Message | Tom Lane | 2007-10-23 23:13:36 | Re: vacuum as flags in PGPROC |