| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL |
| Date: | 2007-10-03 13:58:20 |
| Message-ID: | 20071003135820.GN22596@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Oct 02, 2007 at 10:04:19AM -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >> I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99 percent of the messages coming out of that
> >> routine, I bet. And things would still work correct in 0.9.8.
>
> > Here's an example of what I meant.
>
> +1, but I think you should "#ifndef HAVE_ERR_SET_MARK" the added code.
> Also, maybe try to fopen rather than just fstat?
Done on both, and applied.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2007-10-03 14:01:28 | pgsql: Stripped two symbols that are needed. |
| Previous Message | Magnus Hagander | 2007-10-03 13:57:52 | pgsql: Attempt to open certificate file "manually" using fopen before |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-10-03 14:02:28 | Re: First steps with 8.3 and autovacuum launcher |
| Previous Message | Michael Meskes | 2007-10-03 13:22:35 | Re: ECPG regression tests |