Re: Latest ecpg patch broke MSVC build

From: "Magnus Hagander" <magnus(at)hagander(dot)net>
To: Hannes(at)HannesEder(dot)net
Cc: andrew(at)dunslane(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us, meskes(at)postgresql(dot)org, itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Latest ecpg patch broke MSVC build
Date: 2007-10-03 06:05:55
Message-ID: 20071003061222.1D6AFDCC7C9@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > Since this is an actual API library, perhaps a proper fix is to create a
> > .def file listing the exports in it, the same way we do for libpq? And then
> > we could (should!) also filter the exports the same ways as we do for libpq
> > these days.
> >
> > (see the exports.txt file in libpq)
> >
> > I'll try to find time to look forther at this meanwhile, but if someone can
> > confirm that donig an explicit export list is a good way to go, I can
> > confirm that donig that fixes the build problem :-)
> >
> > //Magnus
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: explain analyze is your friend
> >
>
> According to:
>
> Module-Definition (.def) File EXPORT
> http://msdn2.microsoft.com/en-us/library/ms856515.aspx
>
> whitespace is required between the name and the ordinal in a
> .def-file, hence in the .def-file DllMain @12 should be used
> instead of DllMain(at)12(dot)

you're reading the problem wrong. The 12 is not the ordinal, it's a part of the decorated name.

/Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannes Eder 2007-10-03 07:35:51 Re: Latest ecpg patch broke MSVC build
Previous Message Tom Lane 2007-10-03 01:48:49 Re: Re: [COMMITTERS] pgsql: Fix free space map to correctly track the total amount of FSM