Skip site navigation (1) Skip section navigation (2)

Re: Latest ecpg patch broke MSVC build

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>,Michael Meskes <meskes(at)postgresql(dot)org>,ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: Latest ecpg patch broke MSVC build
Date: 2007-10-01 10:34:02
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Sun, Sep 30, 2007 at 11:46:00PM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > It is building with thread.c but it should not be unless I am misreading 
> > the Makefile. The makefile processing in doesn't look nearly 
> > powerful enough to handle this:
> >   # thread.c is needed only for non-WIN32 implementation of path.c
> >   ifneq ($(PORTNAME), win32)
> >   OBJS += thread.o
> >   endif
> Hmm, sounds like a problem, but why was it not a problem before?

It's not realliy a problem since the stuff in thread.c is #ifdefed away on
Windows in most cases anyway. All we do is import a small piece of code
we'll never use..


In response to

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2007-10-01 10:54:33
Subject: Re: msvc >= VC7 understands __FUNCTION__
Previous:From: Magnus HaganderDate: 2007-10-01 09:17:33
Subject: Re: Latest ecpg patch broke MSVC build

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group