| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Meskes <meskes(at)postgresql(dot)org>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Latest ecpg patch broke MSVC build |
| Date: | 2007-10-01 10:34:02 |
| Message-ID: | 20071001103402.GE387@svr2.hagander.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 30, 2007 at 11:46:00PM -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > It is building with thread.c but it should not be unless I am misreading
> > the Makefile. The makefile processing in Project.pm doesn't look nearly
> > powerful enough to handle this:
>
> > # thread.c is needed only for non-WIN32 implementation of path.c
> > ifneq ($(PORTNAME), win32)
> > OBJS += thread.o
> > endif
>
> Hmm, sounds like a problem, but why was it not a problem before?
It's not realliy a problem since the stuff in thread.c is #ifdefed away on
Windows in most cases anyway. All we do is import a small piece of code
we'll never use..
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2007-10-01 10:54:33 | Re: msvc >= VC7 understands __FUNCTION__ |
| Previous Message | Magnus Hagander | 2007-10-01 09:17:33 | Re: Latest ecpg patch broke MSVC build |