Re: docfix - DELETE doesn't affect auto-analyze

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: docfix - DELETE doesn't affect auto-analyze
Date: 2007-07-18 04:17:52
Message-ID: 20070718041752.GA4586@alvh.no-ip.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> - is compared to the total number of tuples inserted, updated, or deleted
> >> + is compared to the total number of tuples inserted or updated
>
> As best I can tell, this description is even further away from the
> actual CVS HEAD behavior than the previous one. The code is comparing
> against
>
> anltuples = tabentry->n_live_tuples + tabentry->n_dead_tuples -
> tabentry->last_anl_tuples;
>
> and deletions surely increase n_dead_tuples.

I think the patch is correct for 8.1 and 8.2 but is wrong for HEAD
(disclaimer: I'm a bit sleepy ATM).

--
Alvaro Herrera http://www.advogato.org/person/alvherre
Management by consensus: I have decided; you concede.
(Leonard Liu)

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2007-07-18 04:18:50 Re: docfix - DELETE doesn't affect auto-analyze
Previous Message ITAGAKI Takahiro 2007-07-18 04:16:38 Re: docfix - DELETE doesn't affect auto-analyze