Skip site navigation (1) Skip section navigation (2)

Re: ECPG threads test

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <Michael(dot)Meskes(at)credativ(dot)de>
Subject: Re: ECPG threads test
Date: 2007-03-28 21:03:54
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Magnus Hagander wrote:
> Bruce Momjian wrote:
> > Magnus Hagander wrote:
> >> Hi!
> >>
> >> >From what I can see, the ecpg thread tests (src/interfaces/ecpg/threads)
> > 
> > Uh, the directory src/interfaces/ecpg/threads doesn't exist.  I assume
> > you mean src/interfaces/ecpg/test/thread.
> Yes, that's what I mean. Sorry 'bout that.
> >> don't ever run. They rely on ENABLE_THREAD_SAFETY to be set, but even when
> >> I build with --enable-thread-safety, it's not set. This is because ecpg
> >> does not pull in pg_config.h, and also does not specify it on the
> >> commandline.
> > 
> > Yep, that's a problem.  Michael Meskes committed thoses files on
> > 2006/08/02 so I am hoping he can address it.
> Ok. At least I'm not completely lost then.
> I'll see if I can put something together while I do the rest of that
> work, but if Michael (or someone else) has a quick-fix, go ahead.

I believe the solution is to test in the Makefile, and just not call the
thread part at all unless threading is enabled.  Doing the thread test
in the C code is not going to work because it will not produce output
that matches the expected file.

  Bruce Momjian  <bruce(at)momjian(dot)us>

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2007-03-28 21:04:59
Subject: Re: Patch queue concern
Previous:From: Bruce MomjianDate: 2007-03-28 21:02:34
Subject: Re: Patch queue concern

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group