| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: I want to omit the fopen message of Windows. |
| Date: | 2007-02-28 16:00:30 |
| Message-ID: | 20070228160030.GA31842@svr2.hagander.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Wed, Feb 28, 2007 at 09:04:58AM +0100, Magnus Hagander wrote:
> On Wed, Feb 28, 2007 at 02:20:01AM -0500, Tom Lane wrote:
> > "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> > > Is this message necessary for setting errno again?
> >
> > AFAIR we only intended that message as a temporary measure until we'd
> > figured out why things seemed to be failing on Windows. If there's no
> > longer a need, I'd vote for removing the whole code chunk, not just
> > stepping the level down by one. But if you are still seeing it, maybe
> > we haven't figured out why the failure?
>
> No, you see it during normal startup - for example, pg_internal.init
> does not exist at this time. So don't think it's needed - I'll zap it in
> a bit if noone objecst.
Removed.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2007-02-28 17:24:58 | Re: POSIX Shared memory, revised, again |
| Previous Message | Gregory Stark | 2007-02-28 15:41:20 | Updated Packed Varlena (relative to CVS post SET_VARSIZE changes) |