Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-patches] Patch to avoid gprofprofilingoverwrites

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Nikhil S <nikhil(dot)sontakke(at)enterprisedb(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Korry Douglas <korryd(at)enterprisedb(dot)com>
Subject: Re: [pgsql-patches] Patch to avoid gprofprofilingoverwrites
Date: 2007-02-20 02:31:27
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
OK, I took Korry's gmon.out patch and Nikhil's patch and
made a combined version.  It seems the gmon.out and -pg flags are
GCC-specific, rather than being platform-specific, so what I did was to
allow --enable-profiling to only work with GCC.

Patch attached.


Nikhil S wrote:
> Hi Bruce,
> I saw this mail of yours a bit late. Have coded up a patch to accept 
> --enable-profiling via configure. It is attached with this mail.
> It stores the flag in the src/template/linux file.
> If you have not started working on it, maybe you can review this and 
> forward it to Korry if this is useful?
> Regards,
> Nikhils
> Bruce Momjian wrote:
> > korryd(at)enterprisedb(dot)com wrote:
> >   
> >>>>> What about a "--enable-gprof" (or "--enable-profiling"?) configure
> >>>>> flag? This could add the appropriate compiler flags to CFLAGS, enable
> >>>>> LINUX_PROFILE if on Linux, and enable the "gprof/pid" mkdir().
> >>>>>           
> >>>> That would really only work for GCC, wouldn't it?
> >>>>         
> >>> Well, yeah, but that's what many of us use anyway.  I would envision it
> >>> as adding $(PROFILE) to CFLAGS, and then there would be one place
> >>> to adjust "-pg" to something else for another compiler --- perhaps the
> >>> template files could be given a chance to change PROFILE to something
> >>> else.
> >>>       
> >> I don't feel competent to muck around with (sorry, I'm not
> >> tying to shirk the work, I've just never had any success in writing
> >> configure/automake/autoconf stuff - I have the "leaping goats" book, but
> >> I need a small meaningful example to start with).  
> >>
> >> Can someone else volunteer to make this change?  And then forward the
> >> patch to me so I can learn something useful about how to change
> >> without breaking it?
> >>     
> >
> > I can work on this.
> >
> >   

  Bruce Momjian  <bruce(at)momjian(dot)us>

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /rtmp/diff
Description: text/x-diff (9.4 KB)


pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-02-20 02:50:07
Subject: Re: [HACKERS] \copy (query) delimiter syntax error
Previous:From: ITAGAKI TakahiroDate: 2007-02-20 02:03:33
Subject: Re: Error correction for n_dead_tuples

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group