Fix up plpgsql's "simple expression" evaluation mechanism so that it behaves
safely in the presence of subtransactions. To ensure that any ExprContext
shutdown callbacks are called at the right times, we have to have a separate
EState for each level of subtransaction. Per "TupleDesc reference leak" bug
report from Stefan Kaltenbrunner.
Although I'm convinced the code is wrong as far back as 8.0, it doesn't seem
that there are any ways for the problem to really manifest before 8.2: AFAICS,
8.0 and 8.1 only use the ExprContextCallback mechanism to handle set-returning
functions, which cannot usefully be executed in a "simple expression" anyway.
Hence, no backpatch before 8.2 --- the risk of unforeseen breakage seems
to outweigh the chance of fixing something.
pl_exec.c (r1.180 -> r22.214.171.124)
pl_handler.c (r1.33 -> r126.96.36.199)
plpgsql.h (r1.81 -> r188.8.131.52)
pgsql-committers by date
|Next:||From: Neil Conway||Date: 2007-01-28 16:16:54|
|Subject: pgsql: Add a new builtin type, "uuid".|
|Previous:||From: Tom Lane||Date: 2007-01-28 16:15:50|
|Subject: pgsql: Fix up plpgsql's "simple expression" evaluation mechanism so that |