Re: [HACKERS] Win32 WEXITSTATUS too

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Win32 WEXITSTATUS too
Date: 2007-01-22 20:33:22
Message-ID: 200701222033.l0MKXMR02768@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> >> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >>> FYI, here are the URL's I mention in our source code:
> >>> * Wine (URL used in our error messages) -
> >>> * http://source.winehq.org/source/include/ntstatus.h
> >>> * Descriptions - http://www.comp.nus.edu.sg/~wuyongzh/my_doc/ntstatus.txt
> >>> * MS SDK - http://www.nologs.com/ntstatus.html
> >> I don't have a problem with mentioning those in a source code comment.
> >> I question the wisdom of putting any of them in the error message ...
> >> especially seeing that you haven't even found an "official" Microsoft
> >> page to link to. None of those look to me like they're stable enough
> >> to expect to still be there in three or four years.
> >
> > Agreed. I propose we put the file in src/tools/msvc and link to our CVS
> > source tree or something.
> >
> Uh, AFAIK they're not MSVC specific, but also apply to mingw.
> src/tools/msvc is msvc only - if we stick mingw stuff in there, people
> looking for mingw might miss it..

OK, maybe /doc or src/tools. A more radical approach would be to put
the list in our documentation, or have initdb install it.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-22 20:36:10 Re: [HACKERS] Win32 WEXITSTATUS too
Previous Message Magnus Hagander 2007-01-22 20:13:10 Re: [HACKERS] Win32 WEXITSTATUS too