pgsql: Fix regex_fixed_prefix() to cope reasonably well with regex

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix regex_fixed_prefix() to cope reasonably well with regex
Date: 2007-01-03 22:40:04
Message-ID: 20070103224004.B67859FA48F@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix regex_fixed_prefix() to cope reasonably well with regex patterns of the
form '^(foo)$'. Before, these could never be optimized into indexscans.
The recent changes to make psql and pg_dump generate such patterns (for \d
commands and -t and related switches, respectively) therefore represented
a big performance hit for people with large pg_class catalogs, as seen in
recent gripe from Erik Jones. While at it, be more paranoid about
case-sensitivity checking in multibyte encodings, and fix some other
corner cases in which a regex might be interpreted too liberally.

Tags:
----
REL7_3_STABLE

Modified Files:
--------------
pgsql/src/backend/utils/adt:
selfuncs.c (r1.119.2.9 -> r1.119.2.10)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/selfuncs.c.diff?r1=1.119.2.9&r2=1.119.2.10)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-01-04 00:57:51 pgsql: Fix erroneous implementation of -s in postmaster.c (the switch
Previous Message Tom Lane 2007-01-03 22:39:57 pgsql: Fix regex_fixed_prefix() to cope reasonably well with regex