Skip site navigation (1) Skip section navigation (2)

Re: column ordering, was Re: [PATCHES] Enums patch v2

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>,pgsql-hackers(at)postgresql(dot)org,Martijn van Oosterhout <kleptog(at)svana(dot)org>,Andrew Dunstan <andrew(at)dunslane(dot)net>,Gregory Stark <stark(at)enterprisedb(dot)com>
Subject: Re: column ordering, was Re: [PATCHES] Enums patch v2
Date: 2006-12-20 04:12:50
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackerspgsql-patches
* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> If you can show me a reasonably bulletproof or machine-checkable way to
> keep the two kinds of column numbers distinct, I'd be all for it.  But
> without that, the answer will remain no.

Force references to go through macros which implement the lookup for the
appropriate type?  ie: LOGICAL_COL(table_oid,2) vs.
PHYSICAL_COL(table_oid,1)  Perhaps that's too simplistic.  I guess my
feeling on how this would be approached would be that there'd simply be
a level where logical columns are used and a seperate level where
physical columns are used.  Perhaps the storage layer isn't well enough
abstracted for that though.  Another possibility would be to declare
seperate structures for them (or do something else along those lines,
aka, whatever it is the Linux kernel does) and get the compiler to whine
whenever the typing isn't followed correctly.

Just tossing some thoughts out there, I'd *really* like to have
movable-columns and the ability to add columns in where they're most
appropriate instead of off on the end...  If we can settle on an
approach to deal with Tom's concern I'd be willing to look at updating
the patch to implement it though it's not really high enough that I can
promise anything.



In response to


pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-12-20 04:16:06
Subject: Re: Companies Contributing to Open Source
Previous:From: Tom LaneDate: 2006-12-20 04:08:30
Subject: Re: PQencryptPassword() and encoding

pgsql-patches by date

Next:From: Tom LaneDate: 2006-12-20 04:29:24
Subject: Re: column ordering, was Re: [PATCHES] Enums patch v2
Previous:From: Takayuki TsunakawaDate: 2006-12-20 04:06:37
Subject: Re: Load distributed checkpoint

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group