pgsql: Fix string_to_array() to correctly handle the case where there

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix string_to_array() to correctly handle the case where there
Date: 2006-10-07 00:11:59
Message-ID: 20061007001159.B669B9FB43E@postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix string_to_array() to correctly handle the case where there are
overlapping possible matches for the separator string, such as
string_to_array('123xx456xxx789', 'xx').
Also, revise the logic of replace(), split_part(), and string_to_array()
to avoid O(N^2) work from redundant searches and conversions to pg_wchar
format when there are N matches to the separator string.
Backpatched the full patch as far as 8.0. 7.4 also has the bug, but the
code has diverged a lot, so I just went for a quick-and-dirty fix of the
bug itself in that branch.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
pgsql/src/backend/utils/adt:
varlena.c (r1.139.2.3 -> r1.139.2.4)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/varlena.c.diff?r1=1.139.2.3&r2=1.139.2.4)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-10-07 00:12:05 pgsql: Fix string_to_array() to correctly handle the case where there
Previous Message Tom Lane 2006-10-07 00:11:54 pgsql: Fix string_to_array() to correctly handle the case where there