| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Fetter <david(at)fetter(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Numeric overflow problem + patch |
| Date: | 2006-09-28 21:16:56 |
| Message-ID: | 20060928211656.GE16473@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Thu, Sep 28, 2006 at 05:11:43PM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > ! DETAIL: A field with precision 4, scale 4 must have an absolute value less than 1.
> > [ becomes ]
> > ! DETAIL: A field with precision 4, scale 4 must have an absolute value less than 1 - 5 * 10^-5.
>
> This strikes me as overly pedantic. The message needs to be clear,
> and the proposed change will just confuse people.
I don't know if the code can detect the difference, but a message like:
A field with precision 4, scale 4 must *round to* an absolute value less than 1
Since that more accurately describes the actual problem.
Have a ncie day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | AgentM | 2006-09-28 21:17:16 | Re: Darwin stuff is getting deprecated |
| Previous Message | Magnus Hagander | 2006-09-28 21:11:56 | Re: JAVA Support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2006-09-28 21:19:10 | Re: [HACKERS] Numeric overflow problem + patch |
| Previous Message | Tom Lane | 2006-09-28 21:11:43 | Re: [HACKERS] Numeric overflow problem + patch |