Re: LDAP lookup of connection parameters

Albe Laurenz wrote:
> Bruce Momjian wrote:
> > Albe Laurenz wrote:
> >> This patch for libpq allows you to enter an LDAP URL in
> pg_service.conf.
> >> The URL will be queried and the resulting string(s) parsed for
> >> keyword = value connection options.
> >
> > I have heavily modified your patch to be clearer. Please review the
> > attached version and test it to make sure it still works properly.
> > Thanks.
>
> Most of your modifications are fine, but a quick look tells me that your
> modifications in the parsing of the LDAP URL have been too invasive,
> e.g.:
>
> - you look for the port number in the 'dn' and not in the 'hostname'
> - you check the validity of 'scopestr' and 'attrs[0]' before it is
> '\0'-terminated
>
> Would you prefer that I try to fix your fixes (and stick with your
> coding style)
> or do you want another go?

Thanks for the review. Updated patch attached. Is that OK?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +