Albe Laurenz wrote:
> Bruce Momjian wrote:
> > Albe Laurenz wrote:
> >> This patch for libpq allows you to enter an LDAP URL in
> >> The URL will be queried and the resulting string(s) parsed for
> >> keyword = value connection options.
> > I have heavily modified your patch to be clearer. Please review the
> > attached version and test it to make sure it still works properly.
> > Thanks.
> Most of your modifications are fine, but a quick look tells me that your
> modifications in the parsing of the LDAP URL have been too invasive,
> - you look for the port number in the 'dn' and not in the 'hostname'
> - you check the validity of 'scopestr' and 'attrs' before it is
> Would you prefer that I try to fix your fixes (and stick with your
> coding style)
> or do you want another go?
Thanks for the review. Updated patch attached. Is that OK?
Bruce Momjian bruce(at)momjian(dot)us
+ If your life is a hard drive, Christ can be your backup. +
In response to
pgsql-patches by date
|Next:||From: Greg Stark||Date: 2006-07-26 16:47:57|
|Subject: Re: [HACKERS] Resurrecting per-page cleaner for btree|
|Previous:||From: Tom Lane||Date: 2006-07-26 16:09:04|
|Subject: Re: [HACKERS] Resurrecting per-page cleaner for btree |