| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Non-transactional pg_class, try 2 |
| Date: | 2006-06-12 19:05:07 |
| Message-ID: | 20060612190507.GD4035@alvh.no-ip.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> Or, set it to (0,1) and reserve that TID as a dummy entry. What I'm
> afraid of here is scribbling on some other relation's entry. I'd like
> to see some defense against that, don't much care what.
>
> We do plenty of disable-this-in-bootstrap-mode checks, so one more
> doesn't seem like a problem; so the first solution may be better.
New version of the patch, including fixes to all the feedback you
provided. Thanks!
I used a dummy entry in (0,1), which seems cleaner to me (the
index-creation stuff in bootstrap is apparently still needed to generate
sinval messages, so it's not as easy as returning early from the
function). Maybe we could include a step in initdb to get rid of it,
but it doesn't seem too much of an issue.
| Attachment | Content-Type | Size |
|---|---|---|
| fixclass-4.patch | text/plain | 76.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim C. Nasby | 2006-06-12 19:06:28 | Re: CSV mode option for pg_dump |
| Previous Message | Bill Bartlett | 2006-06-12 19:04:55 | Re: CSV mode option for pg_dump |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2006-06-12 21:39:08 | ADD/DROPS inherits |
| Previous Message | Greg Stark | 2006-06-12 19:01:48 | Re: ADD/DROP INHERITS |