| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Glaesemann <grzm(at)myrealbox(dot)com>, pgsql-patches(at)postgreSQL(dot)org, pgsql-interfaces(at)postgreSQL(dot)org |
| Subject: | Re: Proposed p.tch for error locations |
| Date: | 2006-03-13 15:32:09 |
| Message-ID: | 20060313153209.GA15002@surnet.cl |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-interfaces pgsql-patches |
Tom Lane wrote:
> The change in behavior would actually be in libpq, because it's
> PQerrorMessage that is doing the deed (assuming a reasonably modern
> server and libpq). What I was considering proposing was that we migrate
> the error-cursor feature out of psql and into PQerrorMessage. This
> would mean that you'd get responses like
>
> ERROR: column "foo" does not exist
> LINE 1: select foo from a;
> ^
This doesn't work on terminal using a variable-width font, does it?
Sure, you can have all the interfaces use a monospace font, but it seems
a weird thing to do. I think the line/character position should be
returned in a separate error attribute in ereport. So for example
pgAdmin could count characters and mark it in bold or use a different
color.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-03-13 15:44:24 | Re: Proposed patch for error locations |
| Previous Message | Tom Lane | 2006-03-13 15:11:31 | Re: [PATCHES] Proposed patch for error locations |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-03-13 15:44:24 | Re: Proposed patch for error locations |
| Previous Message | Tom Lane | 2006-03-13 15:11:31 | Re: [PATCHES] Proposed patch for error locations |