Re: [GENERAL] Number format problem

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Daniel Verite <daniel(at)manitou-mail(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [GENERAL] Number format problem
Date: 2006-02-12 23:56:15
Message-ID: 200602122356.k1CNuFj14534@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> This patch broke the regression tests. It seems to change the C-locale
> >> behavior on many platforms.
>
> > Oh, so C locale has "" for thousands_sep? Hmm. So there is no way to
> > disinguish "" as "don't have" from "" as "don't want". Will revert.
>
> Possibly we could special-case C locale, and allow an empty string only
> when not C locale. However, it could be that there are other locales
> where the change would surprise people, too :-(

Not sure. Peter stated the French locale was wrong for the Debian they
were using, and he should know, so I am going to wait for more feeback.

One thing that has me confused is that psql/print.c doesn't check for a
zero-length string for thousands_sep in setDecimalLocale, so I am not
thinking that is wrong and should skip "" like we do in formatting.c.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Chris 2006-02-12 23:57:14 Re: Insert more than one t-uple in a single sql
Previous Message Tom Lane 2006-02-12 23:51:00 Re: [GENERAL] Number format problem

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2006-02-13 01:45:53 Re: Uninstall scripts for contrib
Previous Message Tom Lane 2006-02-12 23:51:00 Re: [GENERAL] Number format problem