Re: Odbcapi30.c - 64 bit compiler warning cleanup

From: Ludek Finstrle <luf(at)pzkagis(dot)cz>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ludek Finstrle <luf(at)pzkagis(dot)cz>, pgsql-odbc(at)postgresql(dot)org
Subject: Re: Odbcapi30.c - 64 bit compiler warning cleanup
Date: 2006-01-26 20:58:13
Message-ID: 20060126205813.GA12369@soptik.pzkagis.cz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

> > > >> I don't solve the problem in options.c where 64-bit pointer may
> > > >> be passwd throught 32-bit number. I don't know how to solve it.
> > >
> > > > No nor I. Any chance of a little help with this one please Tom?
> > >
> > > I assume that you can't alter the signature of PGAPI_SetConnectOption,
> > > ie, vParam really has to be SQLUINTEGER and not some other type?
> >
> > The spec actually says it should be a SQLPOINTER. Changing to that
> > unleashes a whole barrel of extra fun unfortunately.
>
> I don't think it will be so problematic. I'll try it. It's the best way
> to support Win64.

Here is my result. Patch attached. I have no 64-bit box ready at hand here.
I will test it on 64-bit box tomorrow.

Please review and comment

Luf

Attachment Content-Type Size
psqlodbc-64bit_SetConnectOption.diff text/plain 9.3 KB

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Ludek Finstrle 2006-01-27 08:25:40 Re: Odbcapi30.c - 64 bit compiler warning cleanup
Previous Message Jaime Casanova 2006-01-26 19:34:39 Re: is there a default client encoding?