|From:||Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>|
|Cc:||Luke Lonergan <llonergan(at)greenplum(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Ben Gould <ben(dot)gould(at)free(dot)fr>|
|Subject:||Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of|
|Views:||Raw Message | Whole Thread | Download mbox|
> Luke Lonergan wrote:
> > Bruce,
> > On 12/27/05 10:20 AM, "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > > OK, original patch applied to HEAD and smaller version to 8.1.X, and
> > > regression test added, now attached.
> > Great, good catch.
> > Have you tested performance, before and after?
> > The only good way to test performance is using a fast enough I/O subsystem
> > that you are CPU-bound, which means >60MB/s of write speed.
> > I'd be happy to get you an account on one.
> I don't need to test performance because it is the same code, just with
> macros and the two functions merged. I do have an optimization for that
> loop but I saw no improvement so I didn't apply it. It was basically to
> advance the pointer in a tight look just checking for \r, \n, and \\,
> but it seems the larger loop isn't much slower than a tight one.
Here is the patch I was testing. I don't see any win on my hardware,
but it isn't a huge machine, so you might see an improvement on your
hardware, and if you do, we can consider applying it.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
|Next Message||Bruce Momjian||2005-12-28 03:46:28||Re: BUG #2129: dblink problem|
|Previous Message||Bruce Momjian||2005-12-28 03:27:57||Re: [BUGS] BUG #2114: (patch) COPY FROM ... end of|