Re: CVS of 8.1.x MS-VC6 probrem.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Hiroshi Saito <saito(at)inetrt(dot)skcapi(dot)co(dot)jp>
Subject: Re: CVS of 8.1.x MS-VC6 probrem.
Date: 2005-12-09 14:45:36
Message-ID: 200512091445.jB9Eja827246@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> > While I have applied your patch, I am now confused about
> > something. Your change was to pg_config.h.win32, which is
> > used only for WIN32_CLIENT_ONLY compiles, namely MSVC and Borland C.
> >
> > The addition was:
> >
> > /* use _snprintf and _vsnprintf */
> > #define HAVE_DECL_SNPRINTF 1
> > #define snprintf _snprintf
> > #define HAVE_DECL_VSNPRINTF 1
> > #define vsnprintf _vsnprintf
> >
> > Now, I think the problem is that with those defines, we will
> > not use our port/snprintf.c, meaning the %$ escapes for
> > language translation will not work for those builds. I
> > realize the backend is the most important for messages, but
> > libpq and psql also have message translation.
>
> AFAIK we don't support NLS builds with MSVC anyway. (Check
> pg_config.h.win32, it has no #define NLS). So I don't think this is an
> issue.

Right, thanks. Sorry for the confusion.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-12-09 14:46:08 Re: CVS of 8.1.x MS-VC6 probrem.
Previous Message Bruce Momjian 2005-12-09 14:45:20 Re: CVS of 8.1.x MS-VC6 probrem.