pgsql: Rearrange code in ExecInitBitmapHeapScan so that we don't

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Rearrange code in ExecInitBitmapHeapScan so that we don't
Date: 2005-12-02 01:29:55
Message-ID: 20051202012955.7CB359DD6A4@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Rearrange code in ExecInitBitmapHeapScan so that we don't initialize the
child plan nodes until we have acquired lock on the relation to scan.
The relative order of initialization of plan nodes isn't real important in
other cases, but it's critical here because one is supposed to lock a
relation before its indexes, not vice versa. The original coding was at
least vulnerable to deadlock against DROP INDEX, and perhaps worse things.

Modified Files:
--------------
pgsql/src/backend/executor:
nodeBitmapHeapscan.c (r1.6 -> r1.7)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeBitmapHeapscan.c.diff?r1=1.6&r2=1.7)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-12-02 01:30:27 pgsql: Rearrange code in ExecInitBitmapHeapScan so that we don't
Previous Message Tom Lane 2005-12-02 00:44:41 Re: [COMMITTERS] pgsql: Add comments about why errno is set to zero.