From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Add comments about why errno is set to zero. |
Date: | 2005-12-01 21:31:12 |
Message-ID: | 20051201213108.GC1287@svana.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Thu, Dec 01, 2005 at 04:12:30PM -0500, Bruce Momjian wrote:
> Well, there seems to be enough confusion, even in this email list, that
> identifying _why_ errno is being cleared is a good idea.
>
> I modified it to:
>
> errno = 0; /* avoid having to check the result for failure */
I don't know about others but I find that wording ambiguous. Like it's
saying that once you've done that it can't fail. I think I'd prefer
something like:
errno = 0; /* Make error condition detectable */
or even
errno = 0; /* clear pending errors */
or
errno = 0; /* clear prior detected errors */
YMMV,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-12-01 21:38:56 | Re: [COMMITTERS] pgsql: Add comments about why errno is set |
Previous Message | Alvaro Herrera | 2005-12-01 21:20:51 | Re: [COMMITTERS] pgsql: Add comments about why errno is set to zero. |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-12-01 21:36:34 | Re: SHOW ALL output too wide |
Previous Message | Alvaro Herrera | 2005-12-01 21:20:51 | Re: [COMMITTERS] pgsql: Add comments about why errno is set to zero. |