| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pidfile location missing after restarting crashed server in 8.1 |
| Date: | 2005-10-26 19:51:18 |
| Message-ID: | 20051026195118.GE27006@surnet.cl |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Tom Lane wrote:
> >> Yeah: it's now being accessed by a relative path (relative to $PGDATA,
> >> which we have already chdir'd into at this point).
>
> > So we should include PGDATA in the error message (DataDir actually, I
> > guess).
>
> I don't think that follows. The code prints exactly the path name it's
> using to access the file, and I think that's exactly what it should
> print.
It's not useful for the user that way. Besides, we know what we did
chdir() to, so we could present that information to the user.
--
Alvaro Herrera
"Amanece. (Ignacio Reyes)
El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim C. Nasby | 2005-10-26 20:24:57 | TRAP: FailedAssertion("!((itemid)->lp_flags & 0x01)", File: "nbtsearch.c", Line: 89) |
| Previous Message | Andrew Dunstan | 2005-10-26 19:44:45 | localhost in pgpass file? |