Re: [HACKERS] expanded \df+ display broken in beta4

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paesold <mpaesold(at)gmx(dot)at>, Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] expanded \df+ display broken in beta4
Date: 2005-10-26 00:03:16
Message-ID: 200510260003.j9Q03GQ09494@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> "Michael Paesold" <mpaesold(at)gmx(dot)at> writes:
> > Robert Treat wrote:
> >> ISTM even a GUC to enable/disable would have been better scheme than
> >> what we have now; we are basically leaving no options for those who
> >> found the old behavior useful, while what we had before would at least
> >> let people switch back and forth.
>
> > I think Robert is right here and the new behaviour is a step backwards.
>
> Should we revert the patch for the time being, and take another go at it
> in 8.2?
>
> Is it practical to have the old behavior for \df (and anything else with
> particularly wide output) while still forcing \x off for \d?

Here is a quick patch, not for application, that makes \df+ honor \x,
but not \df. Basicaly verbose honors \x, non-verbose does not. I think
would need renaming of the normal_query variable, and more checking in
the code to make sure we are OK.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 757 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew - Supernews 2005-10-26 00:36:24 Re: add_missing_from breaks existing views
Previous Message Klint Gore 2005-10-25 23:45:10 Re: BUG #1993: Adding/subtracting negative time intervals

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2005-10-26 04:09:28 Re: TODO item - tid <> operator
Previous Message Tom Lane 2005-10-25 21:55:21 Re: expanded \df+ display broken in beta4