From: | dpage(at)pgfoundry(dot)org (User Dpage) |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | psqlodbc - psqlodbc: When EN_Destructor is called it searches through |
Date: | 2005-10-25 07:38:54 |
Message-ID: | 20051025073854.9A1E41125023@pgfoundry.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Log Message:
-----------
When EN_Destructor is called it searches through the connection array
and destroys any connections which belong that environment. Unfortunately
it doesn't NULL out the connection array entry afterwards so a future
call to EN_Destructor can wind up trying to destroy that connection
again if another environment has been allocated at the same address.
Also, shouldn't EN_Destructor hold the CONNS critical section while it
is playing with the connection array?
The attached patch fixes both of these issues and seems to have fixed
the crashes I was observing.
[Tom Hughes]
Modified Files:
--------------
psqlodbc:
environ.c (r1.54 -> r1.55)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/psqlodbc/psqlodbc/environ.c.diff?r1=1.54&r2=1.55)
From | Date | Subject | |
---|---|---|---|
Next Message | User Dpage | 2005-10-25 08:47:50 | pginstaller - pginst: pgAdmin has Slovenian tips now. |
Previous Message | User Dpage | 2005-10-25 07:35:20 | psqlodbc - psqlodbc: This patch fixes a potential segfault that can |