pgsql: [ backpatched to 8.0.X.] > >> 3) I restarted the postmaster both

From: momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: [ backpatched to 8.0.X.] > >> 3) I restarted the postmaster both
Date: 2005-08-12 21:23:10
Message-ID: 20050812212310.8A72452EDB@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
[ backpatched to 8.0.X.]

> >> 3) I restarted the postmaster both times. I got this error
> both times.
> >> :25: ERROR: could not load library "C:/Program
> >> Files/PostgreSQL/8.0/lib/testtrigfuncs.dll": dynamic load error
>
> > Yes. We really need to look at fixing that error message. I had
> > forgotten it completely :-(
>
> > Bruce, you think we can sneak that in after feature freeze? I would
> > call it a bugfix :-)
>
> Me too. That's been on the radar for awhile --- please do
> send in a patch.

Here we go, that wasn't too hard :-)

Apart from adding the error handling, it does one more thing: it changes
the errormode when loading the DLLs. Previously if a DLL was broken, or
referenced other DLLs that couldn't be found, a popup dialog box would
appear on the screen. Which had to be clicked before the backend could
continue. This patch also disables the popup error message for DLL
loads.

I think this is something we should consider doing for the entire
backend - disable those popups, and say we deal with it ourselves. What
do you other win32 hackers thinnk about this?

In the meantime, this patch fixes the error msgs. Please apply for 8.1
and please consider a backpatch to 8.0.

Magnus Hagander

Modified Files:
--------------
pgsql/src/backend/port/dynloader:
win32.c (r1.5 -> r1.6)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/port/dynloader/win32.c.diff?r1=1.5&r2=1.6)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2005-08-12 21:23:19 pgsql: [ backpatched to 8.0.X.] > >> 3) I restarted the postmaster both
Previous Message Bruce Momjian 2005-08-12 21:20:24 pgsql: > Gavin Sherry <swm@linuxworld.com.au> writes: > > I ran across