Skip site navigation (1) Skip section navigation (2)

Re: per user/database connections limit again

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Petr Jelinek <pjmodos(at)parba(dot)cz>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: per user/database connections limit again
Date: 2005-07-25 17:59:10
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Petr Jelinek wrote:
> Bruce Momjian wrote:
> >The new syntax for this command is CREATE/ALTER DATABASE/USER:
> >
> >                | MAX CONNECTIONS Iconst
> >
> >This adds 'max' as a keyword, though at a fairly unreserved level, I
> >think.  Should we use the syntax LIMIT CONNECTIONS so we don't have to
> >add MAX as a keyword at all?
> >
> Yeah I have no problem with LIMIT CONNECTIONS, will you change it or 
> should I do it ?

I will do it.

> btw where has new keyword to be added to not be added "at a fairly 
> unreserved level" ? (MAX is also added to keywords.c in that patch)

Right, I will remove the MAX addition.  parser/gram.y has this comment:

	 * Keyword classification lists.  Generally, every keyword present in
	 * the Postgres grammar should appear in exactly one of these lists.
	 * Put a new keyword into the first list that it can go into without causing
	 * shift or reduce conflicts.  The earlier lists define "less reserved"
	 * categories of keywords.

I will check that your additions are in the right place.

  Bruce Momjian                        |
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Rocco AltierDate: 2005-07-25 21:11:30
Subject: Re: Regression - GNUmakefile - pg_usleep
Previous:From: Stephen FrostDate: 2005-07-25 17:58:17
Subject: Re: [PATCHES] Roles - SET ROLE Updated

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group