Re: pgsql: Update for roles: < * Prevent default re-use

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Bruce Momjian <momjian(at)svr1(dot)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Update for roles: < * Prevent default re-use
Date: 2005-07-01 17:33:50
Message-ID: 200507011733.j61HXoK17100@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stephen Frost wrote:
-- Start of PGP signed section.
> * Bruce Momjian (momjian(at)svr1(dot)postgresql(dot)org) wrote:
> > < * Prevent default re-use of sysids for dropped users and groups
> > > * Prevent default re-use of sysids for dropped users and roles
>
> sysids are gone, roles have Oids, so I don't think this is an issue
> anymore... Users are gone too...
>
> > 450c450
> > < * Add COMMENT ON for all cluster global objects (users, groups, databases
> > > * Add COMMENT ON for all cluster global objects (users, roles, databases
>
> Users are gone, so this would just apply to roles..

Updated.

> > < users and groups with separate DROP commands
> > > users and roles with separate DROP commands
>
> users are gone, there are only roles, so I don't know that they'd need
> separate DROP commands, if that's what this means? We do have DROP ROLE
> and REVOKE ROLE...

The problem is this used in pg_dumpall --clean:

DELETE FROM pg_shadow WHERE usesysid <> (SELECT datdba FROM pg_database WHERE datname = 'template0');

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2005-07-01 17:35:22 pgsql: Clarify: < o Replace crude DELETE FROM method of pg_dumpall for
Previous Message Bruce Momjian 2005-07-01 17:32:22 pgsql: Update for roles: < * Allow limits on per-db/user connections >