Re: Dbsize backend integration

Dave Page wrote:
> > That would do just the
> > toast/index/heap, and pg_relation_size() gets a total of them all, and
> > only works on heap, no index or toast.
>
> The totalling version (whatever it ends up being called) should
> definitely work on toast tables, as it is a legitimate use case to want
> to see the size of such a table and it's indexes, independent of the
> owner table. There is no need for it to work on an index though,
> however, it will return the right answer if it is used that way, so I
> think that trying to prevent it will be unecessary code that simply
> slows down the majority of invocations of the function for no benefit.

Agreed.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073