Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Federico Di Gregorio <fog(at)initd(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector
Date: 2005-06-28 00:44:58
Message-ID: 200506280044.j5S0iw909065@candle.pha.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Later such as in a later postmaster start, but personally I would just
> > remove the option completely.
>
> I don't have a problem with removing it as a writable option ... but
> I'm thinking we should leave it as a read-only GUC parameter (like
> the several others we have already). Otherwise we'll need to add some
> other method of finding out whether the collector is running.

I assume the collector should always be running, and if it isn't, it is
mentioned in the server logs. That seems sufficient.

The following patch removes the GUC stats_start_collector. The stats
process is now always started.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 9.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2005-06-28 00:47:12 Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector = false
Previous Message Robert Grabowski 2005-06-27 15:07:00 BUG #1733: Function visibility in transactions error

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-06-28 00:46:02 Re: replace_text() improvement
Previous Message Bruce Momjian 2005-06-27 23:49:41 Re: regexp_replace